Re: [PATCH][RFC] request_firmware examples and MODULE_FIRMWARE

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

Ar Llu, 2006-09-04 am 01:39 -0700, ysgrifennodd Victor Hugo:
> That said, here's the patch...
> 
> tatic void sample_firmware_load(char *firmware, int size)
+{
+       u8 buf[size + 1];
+       memcpy(buf, firmware, size);

Please don't use this GNUism in the kernel code. It makes it very hard
to tell how much is being put on the (limited) stack. Better to use
kmalloc explicitly or a fixed size.

Rest looks sane.


-- 
VGER BF report: H 1.48569e-10
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/