Re: [PATCH 11/22][RFC] Unionfs: Lookup helper functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>+		if ((bopaque != -1) && (bopaque < bend))

>+	/* If we've only got negative dentries, then use the leftmost one. */
>+	if (lookupmode == INTERPOSE_REVAL) {
>+		if (dentry->d_inode) {
>+			itopd(dentry->d_inode)->uii_stale = 1;
>+		}
>+		goto out;
>+	}
>+		if (!newsize || ((oldsize < newsize) && (newsize > minsize))) {

Some places where -() and -{}

>+static int is_opaque_dir(struct dentry *dentry, int bindex)
>+{
>+	int err = 0;
>+	/* This is an opaque dir iff wh_hidden_dentry is positive */
>+	err = !!wh_hidden_dentry->d_inode;
>+out:
>+	return err;
>+}

This smells like a bool function. If so, don't call it "err" (since boolean
functions do not return "errors").



Jan Engelhardt
-- 

-- 
VGER BF report: H 8.44923e-11
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux