Re: [PATCH 03/16] GFS2: bmap and inode functions

* Jan Engelhardt <[email protected]> wrote:

> >> How about inverting the if() to:
> >> 
> >> 	if(ip == NULL)
> >> 		return;
> >> 	if(test_bit(GLF_DIRTY, &gl->gl_flags))
> >> 		gfs_inode_attr_in(ip);
> >> 	gfs2_meta_cache_flush(ip);
> >
> >btw., it should be "if (", not "if(".
> 
> There is no such rule in CodingStyle.

still it's part of the proper coding style :)

	Ingo

-- 
VGER BF report: H 0
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 03/16] GFS2: bmap and inode functions
    • From: Ingo Molnar <[email protected]>

• References:
  • [PATCH 03/16] GFS2: bmap and inode functions
    • From: Steven Whitehouse <[email protected]>
  • Re: [PATCH 03/16] GFS2: bmap and inode functions
    • From: Jan Engelhardt <[email protected]>
  • Re: [PATCH 03/16] GFS2: bmap and inode functions
    • From: Ingo Molnar <[email protected]>
  • Re: [PATCH 03/16] GFS2: bmap and inode functions
    • From: Jan Engelhardt <[email protected]>

• Prev by Date: Re: [PATCH 03/16] GFS2: bmap and inode functions
• Next by Date: Re: Support for TI FlashMedia (pci id 104c:8033, 104c:803b) flash card readers
• Previous by thread: Re: [PATCH 03/16] GFS2: bmap and inode functions
• Next by thread: Re: [PATCH 03/16] GFS2: bmap and inode functions
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]