Re: [PATCH 2.6.18-rc4-mm3 1/2] fs/cifs: Converting into generic boolean

Jan Engelhardt wrote:

--- a/fs/cifs/asn1.c	2006-09-01 01:24:45.000000000 +0200
+++ b/fs/cifs/asn1.c	2006-09-01 02:43:09.000000000 +0200
@@ -457,7 +457,7 @@ decode_negTokenInit(unsigned char *secur
unsigned char *sequence_end;
unsigned long *oid = NULL;
unsigned int cls, con, tag, oidlen, rc;
-	int use_ntlmssp = FALSE;
+	int use_ntlmssp = false;

Should not this become 'bool use_ntlmssp'? Possibly in a later patch?

I would like to, but there has been complaints on changing 'int''s into 'bool''s, so until there is a more formal decision on this... Of course I would be happy to make a 'int'->'bool'-patch if a maintainer wants it.

Jan Engelhardt

Richard Knutsson

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 2.6.18-rc4-mm3 1/2] fs/cifs: Converting into generic boolean
    • From: Richard Knutsson <[email protected]>
  • Re: [PATCH 2.6.18-rc4-mm3 1/2] fs/cifs: Converting into generic boolean
    • From: Jan Engelhardt <[email protected]>

• Prev by Date: Re: [NFS] [PATCH 019 of 19] knfsd: Register all RPC programs with portmapper by default
• Next by Date: Re: [PATCH 17/17] BLOCK: Make it possible to disable the block layer [try #2]
• Previous by thread: Re: [PATCH 2.6.18-rc4-mm3 1/2] fs/cifs: Converting into generic boolean
• Next by thread: Re: [PATCH 2.6.18-rc4-mm3 1/2] fs/cifs: Converting into generic boolean
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]