Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Correcting error-prone boolean-statement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nathan Scott wrote:

On Fri, Sep 01, 2006 at 03:18:31AM +0200, Richard Knutsson wrote:
Nathan Scott wrote:
Are you using XFS on your systems?  What is your strategy for getting this
runtime tested going to be?  Or are you delegating that responsibility? :)

Sorry, can't say that I do. So pretty please... ;)
Seriously, I can not find a state when this may fail (if not "if (var == TRUE)" happend to be correct for 'var' != 0 != 1, but that is just a bug waiting to happend).
But please correct me if I am wrong.

OK, I'll run with it in my own testing for awhile.

Thanks!

                                                   I was also curious to
why you didn't remove the other few B_TRUE/B_FALSE occurences?  (and the
typedef)?
Working on it. Should be out tomorrow(or in about 20 hours).
From the "Re: Conversion to generic boolean"-thread (started on 06-08-28), there were those who did not seem to like the conversion. But since no-one complained about removing "== B_FALSE/B_TRUE", I thought it best to remove them first and then take the rest from there.

cheers.

cu

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux