Re: [Patch] Uninitialized variable in drivers/net/wan/syncppp.c

Eric Sesterhenn wrote:

Thanks for clarification. Here is an updated patch, which has the advantage
of also silencing the gcc warning.

For len equal to 4, we never call sppp_lcp_conf_parse_options(),
therefore rmagic does not get initialized.

Signed-off-by: Eric Sesterhenn <[email protected]>

--- linux-2.6.18-rc5/drivers/net/wan/syncppp.c.orig	2006-09-01 02:16:18.000000000 +0200
+++ linux-2.6.18-rc5/drivers/net/wan/syncppp.c	2006-09-01 02:16:40.000000000 +0200

@@ -469,7 +469,7 @@ static void sppp_lcp_input (struct spppstruct net_device *dev = sp->pp_if;

 	int len = skb->len;
 	u8 *p, opt[6];
-	u32 rmagic;
+	u32 rmagic = 0;

if (!pskb_may_pull(skb, sizeof(struct lcp_header))) {

 		if (sp->pp_flags & PP_DEBUG)


Acked-by: Paul Fulghum <[email protected]>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [Patch] Uninitialized variable in drivers/net/wan/syncppp.c
  - From: Eric Sesterhenn <[email protected]>
- Re: [Patch] Uninitialized variable in drivers/net/wan/syncppp.c
  - From: Paul Fulghum <[email protected]>
- Re: [Patch] Uninitialized variable in drivers/net/wan/syncppp.c
  - From: Eric Sesterhenn <[email protected]>

Prev by Date: Re: [PATCH 17/17] BLOCK: Make it possible to disable the block layer [try #2]
Next by Date: [PATCH 2.4.33.2] enforce RLIMIT_NOFILE in poll()
Previous by thread: Re: [Patch] Uninitialized variable in drivers/net/wan/syncppp.c
Next by thread: [Patch] Uninitialized variable in drivers/scsi/ncr53c8xx.c
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]