Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.

Ian Campbell wrote:

Are you sure that works? When I tried it didn't. I think because
asm/smp.h isn't included by linux/smp.h for !SMP.

Nah, testing is overrated.

I needed the below to make it work, but including linux/smp.h and
asm/smp.h in the same file smells a bit fishy to me... Probably
acceptable for now if you are thinking of redoing SMP processor bringup
anyway.

That looks OK for now. Rearranging CPU bringup looks a little bit complex to do immediately, so this seems like a reasonable fix for now.

   J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/8] Implement per-processor data areas for i386.
    • From: Jeremy Fitzhardinge <[email protected]>
  • [PATCH 7/8] Implement smp_processor_id() with the PDA.
    • From: Jeremy Fitzhardinge <[email protected]>
  • Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.
    • From: Ian Campbell <[email protected]>
  • Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.
    • From: Jeremy Fitzhardinge <[email protected]>
  • Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.
    • From: Ian Campbell <[email protected]>

• Prev by Date: [PATCH 4/4] NOMMU: Add docs about shared memory
• Next by Date: Re: [RFC] Simple userspace interface for PCI drivers
• Previous by thread: Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.
• Next by thread: [PATCH 1/8] Use asm-offsets for the offsets of registers into the pt_regs struct, rather than having hard-coded constants.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]