Re: [PATCH] RFKILL - Add support for input key to control wireless radio

[Ivo van Doorn <ivdoorn@gmail.com>]

Hi,

> > > I am not sure if this is a correct approach, kernel should not assume
> > > that the reason why input device was opened is to control the state of
> > > the transmitter. For example one could be happy with hardware toggling
> > > the state but still want to have for example a GKrellm showing state
> > > of the transmitter.
> > 
> > Valid point, but when the radio is disabled a wireless interface should
> > report a txpower of 0. I don't know if this is also the case for bluetooth or irda..
> > 
> 
> Exactly...
> 
> > > Also please explain how userspace would control the state of
> > > transmitter once KEY_RFKILL is received - there seems to be only
> > > kernel->userspace link, but not userspace->kernel.
> > 
> > Plain ifconfig actually, the rfkill is intentionally a simple kernel->userspace
> > notification. There are already various ways a interface can be disabled and
> > adding more would in my opinion not be a good thing.
> > The reason for a hardware key event is to do something additionally besides
> > simply turning down the radio of the (registered interfaces) because he might
> > have additional interfaces to be shutdown, or there has to be done something
> > with the interface before the radio is switched off.
> > 
> 
> Well, this assumes that you have a network interface which may not be the
> case. For example I could have a bluetooth keyboard or mouse instead of
> network card. And you are proposing a generic solution...

Correct me if I am wrong, but a IRDA and Bluetooth device will still have
userspace representation with a standard userspace tool right.
And with such a tool it would be normal to have a on/off switch for the radio
I would expect (and would find strange if such a switch is not there)
I have never used bluetooth or IRDA device so I can't talk from
experience here.

> > > I would rather see you implemented a transmitter control framework
> > > that would export couple of sysfs attributes. One attribute would
> > > enable/disable controlling transmitter state automatically by the
> > > driver and another  would allow controlling transmitter from
> > > userspace. Then input device would always deliver events to userspace
> > > (btw, it probably shoudl be switch, not a key event) and it would be
> > > up to userspace program to explicitely take control over.
> > 
> > This can indeed be done, would it not also make the input device redundant?
> > Since userspace could also just poll a sysfs entry, and I on the netdev list the
> > input device seemed to be prefered over sysfs polling.
> >
> 
> Input device is good since then userspace connects to all of them and
> waits for that specific event. The key (or switch) may even be generated
> by another device (for example reassigning a key on my AT keyboard).
> But I would probably keep RF control and input device separate instead of
> mixing into one abstraction layer.

Ok, that would make sense. I'll try to add the sysfs attributes you recommended.
I'll also have to add bluetooth/irda/bluetooth message seperation, since
at the moment pressing the wifi button for example would also
disable bluetooth devices and that is likely not desired by the users, (I already have
received objections about it, with requests to change that behaviour)

Ivo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/