AW: [PATCH] sun disk label: fix signed int usage for sector count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear listmembers,
the change did not change anything apparently - what had had to be expected, as the negative numbers presented for the size of partition three must be caused by some printfs' into /proc/partitions or alike.
If someone would kindly guide me as where to look for this issue I am willing to test - using unsigned should increase the limit by a factor of two - not too much, but neither too bad.
Take care



Dieter Jurzitza


-- 
________________________________________________

HARMAN BECKER AUTOMOTIVE SYSTEMS

Dr.-Ing. Dieter Jurzitza
Manager Hardware Systems
   System Development

Industriegebiet Ittersbach
Becker-Göring Str. 16
D-76307 Karlsbad / Germany

Phone: +49 (0)7248 71-1577
Fax:   +49 (0)7248 71-1216
eMail: [email protected]
Internet: http://www.becker.de
 

> -----Ursprüngliche Nachricht-----
> Von: [email protected] 
> [mailto:[email protected]] Im Auftrag von 
> Jurzitza, Dieter
> Gesendet: Dienstag, 29. August 2006 06:58
> An: [email protected]
> Betreff: AW: [PATCH] sun disk label: fix signed int usage for 
> sector count
> 
> 
> Dear listmembers,
> referring to my own question (and to Jeff Mahoneys email), 
> would it be sufficient to simply change
> 
> - --- linux-2.6.17/fs/partitions/sun.c	2006-01-02 
> 22:21:10.000000000 -0500
> +++ linux-2.6.17.fix/fs/partitions/sun.c	2006-08-26 
> 11:54:54.000000000 -0400
> @@ -74,10 +74,10 @@ int sun_partition(struct parsed_partitio
>  	spc = be16_to_cpu(label->ntrks) * be16_to_cpu(label->nsect);
>  	for (i = 0; i < 8; i++, p++) {
>  		unsigned long st_sector;
> - -		int num_sectors;
> +		unsigned int num_sectors;
>  
>  		st_sector = be32_to_cpu(p->start_cylinder) * spc;
>  		num_sectors = be32_to_cpu(p->num_sectors);
> 
> in order to get rid of the meaningless negative numbers? If 
> possible this would be highly preferrable over a solution 
> that renders this partition useless. If Sun Os cannot handle 
> this, maybe an error message when configuring such a disk 
> would be helpful.
> 
> Once again, thank you for your feedback,
> best regards
> 
> 
> 
> 
> Dieter Jurzitza
> 
> 
> -- 
> ________________________________________________
> 
> HARMAN BECKER AUTOMOTIVE SYSTEMS
> 
> Dr.-Ing. Dieter Jurzitza
> Manager Hardware Systems
>    System Development
> 
> Industriegebiet Ittersbach
> Becker-Göring Str. 16
> D-76307 Karlsbad / Germany
> 
> Phone: +49 (0)7248 71-1577
> Fax:   +49 (0)7248 71-1216
> eMail: [email protected]
> Internet: http://www.becker.de
>  
> 
> > -----Ursprüngliche Nachricht-----
> > Von: [email protected]
> > [mailto:[email protected]] Im Auftrag von 
> > Jurzitza, Dieter
> > Gesendet: Dienstag, 29. August 2006 06:52
> > An: [email protected]
> > Betreff: [PATCH] sun disk label: fix signed int usage for 
> sector count
> > 
> > 
> > Dear listmembers,
> > citing Jeff Mahoney:
> > 
> > > I'm not sure how many people out there are using Sun disk
> > labels with
> > > sizes > 1TB. It seems like a pretty rare corner case, but
> > there's no
> > > reason any data stored in those partitions wouldn't be
> > invalid, and it
> > > will suddenly cut them off. Is this a rare enough
> > occurrence that we
> > > don't care?
> > 
> > I am one of those guys using Sun disklabels with sizes > 1TB.
> > And I would highly appreciate if nobody out there would make 
> > my disk drive useless by simply discarding anything larger 
> > than 1 TB. This would render our department server useless, 
> > what is everything but desirable :-)
> > 
> > Fdisk says:
> > 
> > Kommando (m für Hilfe):
> > Disk /dev/sda (Sun disk label): 1024 heads, 63 sectors, 36187 
> > cylinders Units = Zylinder of 64512 * 512 bytes
> > 
> >     Gerät Flag    Start       End    Blocks   Id  System
> > /dev/sda1             0         1     32256   83  Linux native
> > /dev/sda2  u          1        64   2032128   82  Linux Swap
> > /dev/sda3             0     36187 -980235776    5  Whole disk
> > /dev/sda4            64       320   8257536    1  Boot
> > /dev/sda5           320      4864 146571264   83  Linux native
> > /dev/sda6          4864     16384 371589120   83  Linux native
> > /dev/sda7         16384     36187 638765568   83  Linux native
> > 
> > Kommando (m für Hilfe):
> > 
> > cat /proc/partitions says:
> > /home/fred> cat /proc/partitions
> > major minor  #blocks  name
> > 
> >    8     0 1171874880 sda
> >    8     1      32256 sda1
> >    8     2    2032128 sda2
> >    8     3 -980235776 sda3
> >    8     4    8257536 sda4
> >    8     5  146571264 sda5
> >    8     6  371589120 sda6
> >    8     7  638765568 sda7
> > 
> > but do not leave sda3 useless by changing the code. If there
> > would be a chance to make fdisk and /proc/partitions not to 
> > display negative numbers (since, though obvious, they are 
> > nonsense) it would be preferrable.
> > 
> > Many thanks for your help,
> > take care
> > 
> > 
> > Dieter Jurzitza
> > 
> > --
> > ________________________________________________
> > 
> > HARMAN BECKER AUTOMOTIVE SYSTEMS
> > 
> > Dr.-Ing. Dieter Jurzitza
> > Manager Hardware Systems
> >    System Development
> > 
> > Industriegebiet Ittersbach
> > Becker-Göring Str. 16
> > D-76307 Karlsbad / Germany
> > 
> > Phone: +49 (0)7248 71-1577
> > Fax:   +49 (0)7248 71-1216
> > eMail: [email protected]
> > Internet: http://www.becker.de
> >  
> > 
> > 
> > *******************************************
> > Diese E-Mail enthaelt vertrauliche und/oder rechtlich
> > geschuetzte Informationen. Wenn Sie nicht der richtige 
> > Adressat sind oder diese E-Mail irrtuemlich erhalten haben, 
> > informieren Sie bitte sofort den Absender und loeschen Sie 
> > diese Mail. Das unerlaubte Kopieren sowie die unbefugte 
> > Weitergabe dieser Mail ist nicht gestattet.
> >  
> > This e-mail may contain confidential and/or privileged
> > information. If you are not the intended recipient (or have 
> > received this e-mail in error) please notify the sender 
> > immediately and delete this e-mail. Any unauthorized copying, 
> > disclosure or distribution of the contents in this e-mail is 
> > strictly forbidden.
> > *******************************************
> > 
> > -
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-kernel" in the body of a message to 
> > [email protected] More majordomo info at  
> > http://vger.kernel.org/majordomo-> info.html
> > Please read the 
> > FAQ at  http://www.tux.org/lkml/
> > 
> -
> To unsubscribe from this list: send the line "unsubscribe 
> linux-kernel" in the body of a message to 
> [email protected] More majordomo info at  
> http://vger.kernel.org/majordomo-> info.html
> Please read the 
> FAQ at  http://www.tux.org/lkml/
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux