Re: [ckrm-tech] [PATCH 6/7] BC: kernel memory (core)

On Tue, 2006-08-29 at 18:58 +0400, Kirill Korotaev wrote:
> @@ -274,8 +274,14 @@ struct page {
>         unsigned int gfp_mask;
>         unsigned long trace[8];
>  #endif
> +#ifdef CONFIG_BEANCOUNTERS
> +       union {
> +               struct beancounter      *page_bc;
> +       } bc;
> +#endif
>  }; 

I know you're probably saving this union for when you put some userspace
stuff in here or something.  But, for now, it would probably be best
just to leave it as a plain struct, or even an anonymous union.

You probably had to use gcc 2 when this was written and couldn't use
anonymous unions, right?

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [ckrm-tech] [PATCH 6/7] BC: kernel memory (core)
    • From: Kirill Korotaev <[email protected]>

• References:
  • [PATCH] BC: resource beancounters (v3)
    • From: Kirill Korotaev <[email protected]>
  • [PATCH 6/7] BC: kernel memory (core)
    • From: Kirill Korotaev <[email protected]>

• Prev by Date: ptrace: umoven:
• Next by Date: Why set ORIG_EAX(%esp) to -1 in arch/i386/kernel/entry.S:error_code?
• Previous by thread: Re: [PATCH 6/7] BC: kernel memory (core)
• Next by thread: Re: [ckrm-tech] [PATCH 6/7] BC: kernel memory (core)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]