Re: [PATCH 14/18] 2.6.17.9 perfmon2 patch for review: new i386 files

[Stephane Eranian <eranian@hpl.hp.com>]

Andi,

On Wed, Aug 23, 2006 at 12:58:55PM +0200, Andi Kleen wrote:
> 
> > +
> > +fastcall void smp_pmu_interrupt(struct pt_regs *regs)
> > +{
> 
> This misses enter/exit_idle on x86-64.
> 
I have been working on adding idle notifier for i386.
I am wondering about this code:

/* Called from interrupts to signify idle end */
void exit_idle(void)
{
        if (current->pid | read_pda(irqcount))
                return;
        __exit_idle();
}

And in particular the irqcount. I am guessing you are trying
to protect against nested interrupts. In fact, I think we only
want to get notified once the interrupt stack is fully unwound.
because we get way more exit_idle() than enter_idle().

Is there an irqcount mechanism on i386?

Thanks

--
-Stephane
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/