Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]

On Friday 25 August 2006 22:18, David Howells wrote:
> > > +ifeq ($(CONFIG_MMU),y)
> > > +obj-y                      += bounce.o
> > > +endif
> > 
> > CONFIG_MMU is a bool so you can do this much more elegant:
> > obj-$(CONFIG_MMU) += bounce.o
> 
> In patch 18/18, this changes to:
> 
>         ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy)
> 
> So the elegence in the end is irrelevant.

You could write it as

bounce-$(CONFIG_MMU) += bounce.o
obj-$(CONFIG_BLOCK)  += $(bounce-y)

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]
  - From: Sam Ravnborg <[email protected]>
- [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]
  - From: David Howells <[email protected]>
- Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]
  - From: David Howells <[email protected]>

Prev by Date: Re: [PATCH 2.6.18-rc4 1/5] ieee1394: sbp2: workaround for write protect bit of Initio firmware
Next by Date: Re: Linux v2.6.18-rc5
Previous by thread: Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]
Next by thread: Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]