Re: drivers/char/synclink_gt.c: chars don't have more than 8 bits

Adrian Bunk wrote:

The GNU C compiler (SVN version) spotted the following buggy code indrivers/char/synclink_gt.c:
...

 > Since there are no bits 8 or 9 in a char this code is currently

dead code.


Yes, that is a bug.

Status and data come in byte pairs, bits 9 and 8 are
referenced from the 16 bit combination.

The code is operating on individual bytes in the buffer,
so it should be bits 1 and 0 that are tested.

I will make a patch and post it.

Thanks,
Paul


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- drivers/char/synclink_gt.c: chars don't have more than 8 bits
  - From: Adrian Bunk <[email protected]>

Prev by Date: Re: [PATCH 1/4] net: VM deadlock avoidance framework
Next by Date: Re: [PATCH 4/4] nfs: deadlock prevention for NFS
Previous by thread: drivers/char/synclink_gt.c: chars don't have more than 8 bits
Next by thread: [PATCH] synclink_gt fix receive tty error handling
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]