Re: [PATCH 7/6] Lost bits - fix PG_writeback vs PG_private race in NFS

On Fri, 2006-08-25 at 18:36 +0200, Peter Zijlstra wrote:
> Make sure we clear PG_writeback after we clear PG_private, otherwise
> weird and wonderfull stuff will happen.
> 
NACK.

Look carefully at the case of unstable writes: your patch does nothing
to guarantee that PG_writeback is cleared after PG_private for that
case.
Anyhow, you don't explain exactly what is wrong with clearing
PG_writeback before PG_private.

Cheers,
  Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 7/6] Lost bits - fix PG_writeback vs PG_private race in NFS
    • From: Peter Zijlstra <[email protected]>

• References:
  • [PATCH 0/6] Swap over NFS
    • From: Peter Zijlstra <[email protected]>
  • Re: [PATCH 7/6] Lost bits - fix PG_writeback vs PG_private race in NFS
    • From: Peter Zijlstra <[email protected]>

• Prev by Date: Re: [PATCH 1/3] kthread: update s390 cmm driver to use kthread
• Next by Date: Re: [PATCH 0/4] Compile kernel with -fwhole-program --combine
• Previous by thread: Re: [PATCH 7/6] Lost bits - fix PG_writeback vs PG_private race in NFS
• Next by thread: Re: [PATCH 7/6] Lost bits - fix PG_writeback vs PG_private race in NFS
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]