Re: memory hotplug - looking for good place for cpuset hook

[KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>]

On Fri, 25 Aug 2006 09:57:18 -0700
Paul Jackson <pj@sgi.com> wrote:

> ================================================================
> int add_memory(int nid, u64 start, u64 size)
> {
>         pg_data_t *pgdat = NULL;
>         ...
>         if (!node_online(nid)) {
>                 pgdat = hotadd_new_pgdat(nid, start);
>                 if (!pgdat)
>                         return -ENOMEM;
>                ...
>         }
>         ...
>         if (pgdat) {
>                 /* we online node here. we can't roll back from here. */
>                 node_set_online(nid);
>                 ret = register_one_node(nid);                         
> ================================================================
> 
> Is this second code chunk just as good?
> 

Ah yes. I think yours is better logic.

> I'd still be inclined to add my new cpuset hook to track
> node_online_map right after the node_set_online() call, since
> that's what changes node_online_map.  I don't think I care
> whether or not the "sysfs entry of node" is setup or not.
> 
Ok.

Thanks,
-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/