Re: [PATCH 08/17] BLOCK: Dissociate generic_writepages() from mpage stuff [try #2]

On Thu, Aug 24, 2006 at 10:33:11PM +0100, David Howells wrote:
> From: David Howells <[email protected]>
> 
> Dissociate the generic_writepages() function from the mpage stuff, moving its
> declaration to linux/mm.h and actually emitting a full implementation into
> mm/page-writeback.c.
> 
> The implementation is a partial duplicate of mpage_writepages() with all BIO
> references removed.
> 
> It is used by NFS to do writeback.

This duplication is rather unfortunate, but I don't see a way to distangle
this any better, so ok.

> @@ -693,6 +693,8 @@ out:
>   * the call was made get new I/O started against them.  If wbc->sync_mode is
>   * WB_SYNC_ALL then we were called for data integrity and we must wait for
>   * existing IO to complete.
> + *
> + * !!!! If you fix this you should check generic_writepages() also!!!!

This isn't very elegant comment style :)  What about a little less shouting..

>  int pdflush_operation(void (*fn)(unsigned long), unsigned long arg0);
> +extern int generic_writepages(struct address_space *mapping,
> +			      struct writeback_control *wbc);
>  int do_writepages(struct address_space *mapping, struct writeback_control *wbc);

please try to fit the style of the surrounding prototypes, that is no
'extern'

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 01/17] BLOCK: Move functions out of buffer code [try #2]
    • From: David Howells <[email protected]>
  • [PATCH 08/17] BLOCK: Dissociate generic_writepages() from mpage stuff [try #2]
    • From: David Howells <[email protected]>

• Prev by Date: Re: [PATCH 07/17] BLOCK: Remove dependence on existence of blockdev_superblock [try #2]
• Next by Date: Re: [PATCH 09/17] BLOCK: Move __invalidate_device() to block_dev.c [try #2]
• Previous by thread: [PATCH 08/17] BLOCK: Dissociate generic_writepages() from mpage stuff [try #2]
• Next by thread: [PATCH 06/17] BLOCK: Move bdev_cache_init() declaration to headerfile [try #2]
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]