Re: [PATCH] boot: small change of halt method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew Brukhov wrote:
I'm new here.
After reading boot code i'm immidiatly change this string:

--- ./linux-2.6.17.11/arch/i386/boot/compressed/misc.c	2006-08-24 01:16:33.000000000 +0400
+++ /usr/src/linux-2.6.17.11/arch/i386/boot/compressed/misc.c	2006-08-24 22:36:10.000000000 +0400
@@ -7,6 +7,7 @@
  * malloc by Hannu Savolainen 1993 and Matthias Urlichs 1994
  * puts by Nick Holloway 1993, better puts by Martin Mares 1995
  * High loaded stuff by Hans Lermen & Werner Almesberger, Feb. 1996
+ * Small fix of halt method Andrew Brukhov, Aug. 2006 */ #include <linux/linkage.h>
@@ -289,8 +290,7 @@ static void error(char *x)
 	putstr("\n\n");
 	putstr(x);
 	putstr("\n\n -- System halted");
-
-	while(1);	/* Halt */
+      	asm( "hlt" );
 }

It's becouse this code is platform depended and therefore there is no resons to write infinity cycle.


Wrong.

You need to:

	while (1)
		asm volatile("hlt");

... since HLT only pauses until interrupt.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux