Re: [PATCH] BLOCK: Make it possible to disable the block layer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Woodhouse <[email protected]> wrote:

> >  (*) The contents of a number of filesystem- and blockdev-specific header
> >      files are now contingent on their own configuration options.  This
> >      includes: Ext3/JBD, RAID, MSDOS and ReiserFS.
> 
> Why? Those header files shouldn't be included from anywhere _but_ the
> code in question,

Go and look at fs/compat_ioctl.c.

> and in fact should probably be just moved into fs/foo instead of living in
> include/linux/foo_fs.h.

Definitely.  Patches please:-)

> And please, _never_ make anything dependent on CONFIG_foo_MODULE.

Ah, but...  The core kernel makes use of the certain header files, even when
their actual intended target is compiled as a module.  If I just use
"CONFIG_foo" only, then the module won't compile as a module.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux