Re: [RFC/PATCH] Fixes for ULi5261 (tulip driver)

[Nigel Cunningham <ncunningham@linuxmail.org>]

Hi.

On Wed, 2006-08-23 at 09:56 -0700, Valerie Henson wrote:
> On Wed, Aug 23, 2006 at 11:19:19AM +0200, Pozsar Balazs wrote:
> > 
> > The funny thing is that it seems the _first_ phy_read call always 
> > returns only when the 0x8000 bit is gone (I got this while loop from the 
> > xircom_tulip driver).
> 
> That's pretty much the answer I was suspecting.  Sounds like the read
> is doing some sort of flush.  Unfortunately I can't find any docs, so
> I'd rather keep things as close to the old code as possible to avoid
> breaking other cards.  Does something like this also work?
> 
> 	udelay(500); /* Paranoia - phy_read() may be sufficient */
> 	if (phy_read(db->ioaddr, db->phy_addr, 0, db->chip_id) & 0x8000)
> 		printk("some useful error message");
> 

I got docs from uli earlier in the year, I just never got around to
using them to the extent I intended, and then I switched to working
wirelessly most of the time. I didn't have to sign an NDA to get the
PDF, so it should be okay for me to distribute it, right? If that's the
case, then assuming LKML won't take a PDF, I'll reply again after giving
people time to tell me I'm wrong, removing LKML and giving everyone
directly emailed a copy (it's not huge).

Regards,

Nigel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/