Re: [PATCH] Translate asm version of ELFNOTE macro into preprocessor macro

[ebiederm@xmission.com (Eric W. Biederman)]

Jeremy Fitzhardinge <jeremy@goop.org> writes:

> Ian Campbell wrote:
>>> OK, seems reasonable.  Eric Biederman solved this by having NOTE/ENDNOTE (or
>>> something like that) in his "bzImage with ELF header" patch, but I don't
>>> remember it being used in any way which is incompatible with using a CPP
>>> macro.
>>>
>>
>> I can't find that patch, does NOTE/ENDNOTE just do the push/pop .note
>> section?
>>
>> That would solve the problem with the first argument of the macro being
>> a string but the final argument could still be for .asciz note contents.
>>
>
> It looks like:
>
> .macro note name, type
>      .balign 4
>      .int    2f - 1f            # n_namesz
>      .int    4f - 3f            # n_descsz
>      .int    \type            # n_type
>      .balign 4
> 1:    .asciz "\name"
> 2:    .balign 4
> 3:
> .endm
> .macro enote
> 4:    .balign 4
> .endm
>
>
> so it allows you to put arbitrary stuff in the desc part of the note.  The
> downside is that its a little more cumbersome syntactically for the common case.

I don't expect it to be much more cumbersome, as two pieces, and you need the extra
alignment at the end to ensure each not entry is 4 byte aligned.  Being able to
push and pop a section wouldn't hurt either. 

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/