Re: [RFC][PATCH 1/3] net/ipv4: UDP-Lite extensions

[James Morris <jmorris@namei.org>]

On Wed, 23 Aug 2006, gerrit@erg.abdn.ac.uk wrote:

> +void __init udplite4_register(void)
> +{
> +	if (proto_register(&udplite_prot, 1))
> +		goto out_register_err;
> +
> +	if (inet_add_protocol(&udplite_protocol, IPPROTO_UDPLITE) < 0)
> +		goto out_unregister_proto;
> +
> +	inet_register_protosw(&udplite4_protosw);
> +
> +	return;
> +
> +out_unregister_proto:
> +	proto_unregister(&udplite_prot);
> +out_register_err:
> +	printk(KERN_ERR "udplite4_register: Cannot add UDP-Lite protocol\n");
> +}

Other protocols & network components call panic() if they fail during boot 
initialization.  Not sure if this is a great thing, but it raises the 
issue of whether udp-lite should remain consistent here.



- James
-- 
James Morris
<jmorris@namei.org>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/