On Mon, Aug 21, 2006 at 10:20:12PM -0400, Jeff Dike wrote:
> On Mon, Aug 21, 2006 at 11:56:41PM +0200, Adrian Bunk wrote:
> > arch/um/sys-i386/setjmp.S contains two #ifdef _REGPARM's.
> >
> > Even if regparm was used in i386 uml (which isn't currently done (why?)),
> > I don't see _REGPARM being defined anywhere.
>
> setjmp.S was stolen from klibc, and I'd just as soon leave it alone and
> not try to customize it for UML. That file will disappear if/when klibc
> is in mainline, and I can just pull it in from usr.
Ah, klibc defines _REGPARM if required.
> In general, there's no reason that regparam can't be used for UML. However,
> in the past (I don't know if it's still a problem) gcc miscompiled regparam
> code in the presence of -pg.
I didn't find a corresponding open bug in the gcc Bugzilla.
Can someone verify whether it's still present, and if yes, open a gcc
bug?
> As for why it's not, I don't see any occurences of regparam in include/linux
> or include/asm-i386 either.
It's set globally in arch/i386/Makefile:
cflags-$(CONFIG_REGPARM) += -mregparm=3
That's not pulled by UML, but if there are no outstanding problems with
regparm, we could both enable it uncomditionally on i386 and enable it
on UML/i386.
> > Is this a bug waiting for happening when regparm will be used on uml or
> > do I miss anything?
>
> Probably not.
>
> Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
