Re: [RFC][PATCH] ps command race fix take2 [1/4] list token

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 22 Aug 2006 13:06:34 +0200
Andi Kleen <[email protected]> wrote:

> KAMEZAWA Hiroyuki <[email protected]> writes:
> > 
> > listtoken , a helper for walking a list by intermittent access.
> > 
> > When we walk a list intermittently and the list is being modified at the
> > same time, it's hard to remember our position in it.
> > 
> > With this list token, a user can remember where he is reading by inserting
> > a token in the list.
> 
> I think the header/code needs much more comments so that other people
> can still make sense of it later. Even with the commit log it's not
> quite clear how it works.
> 
Okay, make them more informative.

> Also locking needs to be explained. 
Yes, with RCU. we need appropriate lock.

> I suppose only one user is allowed to use a token at one time?
> 
Yes, I expext that a user uses a token. But several tokens can be inserted to a list.

> But overall it's a good idea to have a generic facility like this.
> I suppose it will be a more common problem in the future.
> 

Thanks,
-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux