Re: [RFC][PATCH] ps command race fix take2 [4/4] proc_pid_readdir

KAMEZAWA Hiroyuki <[email protected]> writes:

> proc_pid_readdir() by list_token.
> 
> Remember 'where we are reading' by inserting a token in the list.
> It seems a bit complicated because of RCU but what we do is very simple.
> 

What happens when you have multiple readers at the same time? Can't
the tokens then be mixed up?

>+		/* this small kmalloc() can fail in rare case, but readdir()
>+		 * is not allowed to return ENOMEM. retrying is reasonable. */

Who disallows this? Such retry loops are normally discouraged 
because they can lead to deadlocks in OOM situations.
I think it would be better to just return ENOMEM.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC][PATCH] ps command race fix take2 [4/4] proc_pid_readdir
    • From: KAMEZAWA Hiroyuki <[email protected]>

• References:
  • [RFC][PATCH] ps command race fix take2 [4/4] proc_pid_readdir
    • From: KAMEZAWA Hiroyuki <[email protected]>

• Prev by Date: Re: [RFC][PATCH] ps command race fix take2 [3/4] profile fix
• Next by Date: [PATCH 1 of 1] x86_43: Put .note.* sections into a PT_NOTE segment in vmlinux
• Previous by thread: Re: [RFC][PATCH] ps command race fix take2 [4/4] proc_pid_readdir
• Next by thread: Re: [RFC][PATCH] ps command race fix take2 [4/4] proc_pid_readdir
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]