KAMEZAWA Hiroyuki <[email protected]> writes:
> proc_pid_readdir() by list_token.
>
> Remember 'where we are reading' by inserting a token in the list.
> It seems a bit complicated because of RCU but what we do is very simple.
>
What happens when you have multiple readers at the same time? Can't
the tokens then be mixed up?
>+ /* this small kmalloc() can fail in rare case, but readdir()
>+ * is not allowed to return ENOMEM. retrying is reasonable. */
Who disallows this? Such retry loops are normally discouraged
because they can lead to deadlocks in OOM situations.
I think it would be better to just return ENOMEM.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
