Re: [PATCH] Signdness issue in drivers/video/intelfb/intelfbdrv.c

On 8/21/06, Eric Sesterhenn <[email protected]> wrote:

hi,

another gcc 4.1 signess warning:

drivers/video/intelfb/intelfbdrv.c:419: warning: comparison of unsigned expression < 0 is always false

since dinfo->mtrr_reg is of the type u32, the error check dinfo->mtrr_reg < 0
is useless. This patch introduces a helper variable, which catches possible
negative error values returned by mtrr_add()

Signed-off-by: Eric Sesterhenn <[email protected]>

NAK.
I've applied a much simpler fix to use make mtrr_reg an int to my
intelfb tree....

Dave.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Signdness issue in drivers/video/intelfb/intelfbdrv.c
    • From: Eric Sesterhenn <[email protected]>

• Prev by Date: Re: [PATCH] intelfb: update doc and Kconfig (supported devices)
• Next by Date: Re: [Patch] restore the RCU callback to defer put_task_struct() Re: Problems with 2.6.17-rt8
• Previous by thread: [PATCH] Signdness issue in drivers/video/intelfb/intelfbdrv.c
• Next by thread: Possible deadlock in videobuf_dma_init_user
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]