Re: [PATCH] misc,acpi,backlight: MSI S270 Laptop support, third try

On Mon, 21 Aug 2006 00:52:09 +0200
Lennart Poettering <[email protected]> wrote:

> +static ssize_t store_auto_brightness(
> +        struct device *dev,
> +        struct device_attribute *attr,
> +        const char *buf, size_t count) {
> +        
> +        int enable, ret;

Please follow the usual kernel coding style, which would yield something like:

static ssize_t store_auto_brightness(struct device *dev,
		struct device_attribute *attr, const char *buf, size_t count)
{
        int enable, ret;

(affects entire patch).

And please also prepare and maintain a standalone changelog.  The one you have here
is full of references to some long-gone email.  Think: "how will my changelog look
when it is in the main git tree".

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] misc,acpi,backlight: MSI S270 Laptop support, third try
    • From: Lennart Poettering <[email protected]>

• Prev by Date: Re: [2.6 patch] re-add -ffreestanding
• Next by Date: Re: [PATCH] cpuset code prevents binding tasks to new cpus
• Previous by thread: [PATCH] misc,acpi,backlight: MSI S270 Laptop support, third try
• Next by thread: Re: [PATCH] misc,acpi,backlight: MSI S270 Laptop support, third try
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]