Re: [Patch] Signedness issue in drivers/net/3c515.c

Ar Llu, 2006-08-21 am 14:05 -0700, ysgrifennodd Andrew Morton:
> 	/* Wait for the stall to complete. */
> 	for (i = 20; i >= 0; i--)
> 		if ((inw(ioaddr + EL3_STATUS) & CmdInProgress) == 0) 
> 			break;
> 
> Your fix will convert this indefinit wait into a bounded one.  It might
> cause the driver to malfunction.

The change is correct. The docs guarantee it can't take that long.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Patch] Signedness issue in drivers/net/3c515.c
    • From: Eric Sesterhenn <[email protected]>
  • Re: [Patch] Signedness issue in drivers/net/3c515.c
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [ckrm-tech] [RFC][PATCH] UBC: user resource beancounters
• Next by Date: Re: Alpha: replacing "extern inline"
• Previous by thread: Re: [Patch] Signedness issue in drivers/net/3c515.c
• Next by thread: Re: [Bugme-new] [Bug 7027] New: CD Ripping speeds slow with 2.6.17
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]