On Friday August 18, [email protected] wrote:
>
> blkdev_open() calls
> do_open(bdev, ...,BD_MUTEX_NORMAL) and takes
> mutex_lock_nested(&bdev->bd_mutex, BD_MUTEX_NORMAL)
>
> then something fails, and we're thrown to:
>
> out_first: where
> if (bdev != bdev->bd_contains)
> blkdev_put(bdev->bd_contains) which is
> __blkdev_put(bdev->bd_contains, BD_MUTEX_NORMAL) which does
> mutex_lock_nested(&bdev->bd_contains->bd_mutex, BD_MUTEX_NORMAL) <--- lockdep trigger
>
> When going to out_first, dbev->bd_contains is either bdev or whole, and
> since we take the branch it must be whole. So it seems to me the
> following patch would be the right one:
Looks sensible to me.
>
> Signed-off-by: Peter Zijlstra <[email protected]>
Acked-by: NeilBrown <[email protected]>
NeilBrown
> ---
> fs/block_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6/fs/block_dev.c
> ===================================================================
> --- linux-2.6.orig/fs/block_dev.c
> +++ linux-2.6/fs/block_dev.c
> @@ -980,7 +980,7 @@ out_first:
> bdev->bd_disk = NULL;
> bdev->bd_inode->i_data.backing_dev_info = &default_backing_dev_info;
> if (bdev != bdev->bd_contains)
> - blkdev_put(bdev->bd_contains);
> + __blkdev_put(bdev->bd_contains, BD_MUTEX_WHOLE);
> bdev->bd_contains = NULL;
> put_disk(disk);
> module_put(owner);
>
>
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
