Re: [PATCH 2.6.18-rc4] aoe [07/13]: jumbo frame support 2 of 2

["Ed L. Cashin" <ecashin@coraid.com>]

On Fri, Aug 18, 2006 at 11:58:32PM +0100, Alan Cox wrote:
> Ar Gwe, 2006-08-18 am 13:39 -0400, ysgrifennodd Ed L. Cashin:
...
> > @@ -28,7 +28,7 @@ new_skb(ulong len)
> >  		skb->protocol = __constant_htons(ETH_P_AOE);
> >  		skb->priority = 0;
> >  		skb_put(skb, len);
> > -		memset(skb->head, 0, len);
> > +		memset(skb->head, 0, ETH_ZLEN);
> 
> You realise the tail of a short packet is cleared by the network drivers
> either in software or hardware ?

Yes, I think that the patch author is used to doing ETH_ZLEN because
of a bug in the e1000 driver where the short packets weren't getting
padded.  I don't think I ever heard of a resolution to that issue, but
I could change it back to "len" here.

-- 
  Ed L Cashin <ecashin@coraid.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/