Re: [PATCH 3/7] [I/OAT] Don't offload copies for loopback traffic

> @@ -1136,7 +1137,8 @@ int tcp_recvmsg(struct kiocb *iocb, stru
>  	skb = skb_peek_tail(&sk->sk_receive_queue);
>  	if (skb)
>  		available = TCP_SKB_CB(skb)->seq + skb->len - (*seq);
> -	if ((available < target) &&
> +	dst = __sk_dst_get(sk);
> +	if ((available < target) && (!dst || (dst->dev != &loopback_dev)) &&

You just added another potential cache miss to a critical
path. A bit flag in the socket would be better.

But is it really worth this ugly special case?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 3/7] [I/OAT] Don't offload copies for loopback traffic
    • From: David Miller <[email protected]>

• References:
  • [PATCH 1/7] [I/OAT] Push pending transactions to hardware more frequently
    • From: Chris Leech <[email protected]>
  • [PATCH 3/7] [I/OAT] Don't offload copies for loopback traffic
    • From: Chris Leech <[email protected]>

• Prev by Date: Re: [PATCH 1/1] network memory allocator.
• Next by Date: Re: [ckrm-tech] [RFC][PATCH 5/7] UBC: kernel memory accounting (core)
• Previous by thread: [PATCH 3/7] [I/OAT] Don't offload copies for loopback traffic
• Next by thread: Re: [PATCH 3/7] [I/OAT] Don't offload copies for loopback traffic
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]