Chuck Lever <[email protected]> wrote:
> > +static uint16_t nfs_server_get_key(const void *cookie_netfs_data,
> > + void *buffer, uint16_t bufmax)
> > +{
>
> Why don't you use the function declaration style that is used in the
> rest of the NFS client?
Actually, the NFS client has several different styles, and mine's not without
precedent, eg:
extern int nfs3_setxattr(struct dentry *, const char *,
const void *, size_t, int);
extern ssize_t nfs_direct_IO(int, struct kiocb *, const struct iovec *, loff_t,
unsigned long);
static inline loff_t
nfs_size_to_loff_t(__u64 size)
> All the parameters belong on one line, don't they?
Depends how much you want to upset those people who tremble with anxiety at
the sight of a line longer than 80 chars.
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
