On 8/18/06, Michal Piotrowski <[email protected]> wrote:
Hi,
I have noticed that sparse generates a lot of "ignoring return value
of 'device_create_file'" warnings.
(cat sparse.txt | grep -c "device_create_file"
1231 :)
I want to fix this warnings, but I'm wondering how to properly handle
return value of device_create_file function.
The shortest way.
int foo()
{
int error;
[..]
error = device_create_file(&bar, &bas)
if (error)
return error;
}
A bit longer way.
int foo()
{
int error;
[..]
error = device_create_file(&bar, &bas)
if (error) {
subsystem_remove_device(bar);
return error;
}
}
Normally you should use 2nd form, especially when foo is a
module_init(foo) as you do not want to have a half-registered device
without supporting code in kernel.
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
