Re: [PATCHv2 2.6.17] net/ipv6/udp.c: remove duplicate udp_get_port code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

In article <[email protected]> (at Thu, 17 Aug 2006 10:56:40 -0400 (EDT)), James Morris <[email protected]> says:

> On Thu, 17 Aug 2006, [email protected] wrote:
> 
> > -			if (inet2->num == snum &&
> > -			    sk2 != sk &&
> > -			    !ipv6_only_sock(sk2) &&
> > -			    (!sk2->sk_bound_dev_if ||
> > -			     !sk->sk_bound_dev_if ||
> > -			     sk2->sk_bound_dev_if == sk->sk_bound_dev_if) &&
> 
> 
> > +		sk_for_each(sk2, node, head)
> > +			if (inet_sk(sk2)->num == snum                        &&
> > +			    sk2 != sk                                        &&
> > +			    (!sk2->sk_reuse        || !sk->sk_reuse)         &&
> > +			    (!sk2->sk_bound_dev_if || !sk->sk_bound_dev_if
> > +			     || sk2->sk_bound_dev_if == sk->sk_bound_dev_if) &&
> 
> 
> Doesn't this change the behavior for IPV6_V6ONLY sockets ?

It is tested in ipv4_rcv_saddr_equal() (called vi saddr_cmp), isn't it?

--yoshfuji
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux