Re: [PATCH 5/7] proc: Factor out an instantiate method from every lookup method.

Hi,


> 
>-out_unlock2:
>+ out:

Whoops a space. I do not mind if you put a space in front of any label, but 
at least be consistent over the whole code :)

>+#ifdef CONFIG_SECURITY
>+	inode->i_nlink += 1;
>+#endif

Maybe ++inode->i_nlink? (Same code block at another place)



Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • The rest of my proc cleanup.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 5/7] proc: Factor out an instantiate method from every lookup method.
    • From: "Eric W. Biederman" <[email protected]>

• Prev by Date: Re: [linux-usb-devel] [PATCH] usb: The HID Simple Driver Interface 0.3.1 (core)
• Next by Date: Re: [PATCH 2/7] pid: Add do_each_pid_task
• Previous by thread: [PATCH 5/7] proc: Factor out an instantiate method from every lookup method.
• Next by thread: [PATCH 4/7] proc: Make the generation of the self symlink table driven.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]