Re: [PATCH 5/7] pid: Implement pid_nr

On 08/15, Eric W. Biederman wrote:
>
> +static inline pid_t pid_nr(struct pid *pid)
> +{
> +	pid_t nr = 0;
> +	if (pid)
> +		nr = pid->nr;
> +	return nr;
> +}

I think this is not safe, you need rcu locks here or the caller should
do some locking.

Let's look at f_getown() (PATCH 7/7). What if original task which was
pointed by ->f_owner.pid has gone, another thread does fcntl(F_SETOWN),
and pid_nr() takes a preemtion after 'if (pid)'? In this case 'pid->nr'
may follow a freed memory.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 5/7] pid: Implement pid_nr
    • From: [email protected] (Eric W. Biederman)

• References:
  • Start using struct pid.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 5/7] pid: Implement pid_nr
    • From: "Eric W. Biederman" <[email protected]>

• Prev by Date: Kprobes - i386 add KPROBE_END macro for .popsection
• Next by Date: Re: [take9 1/2] kevent: Core files.
• Previous by thread: Re: [PATCH 5/7] pid: Implement pid_nr
• Next by thread: Re: [PATCH 5/7] pid: Implement pid_nr
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]