On Wed, Aug 16, 2006 at 02:01:05AM -0700, Roland McGrath wrote:
>
> This fixes a couple of compiler warnings, and adds paranoia checks to boot.
>
> Signed-off-by: Roland McGrath <[email protected]>
> ---
> kernel/kexec.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 50087ec..989c7cd 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -995,7 +995,8 @@ asmlinkage long sys_kexec_load(unsigned
> image = xchg(dest_image, image);
>
> out:
> - xchg(&kexec_lock, 0); /* Release the mutex */
> + locked = xchg(&kexec_lock, 0); /* Release the mutex */
> + BUG_ON(!locked);
> kimage_free(image);
>
> return result;
> @@ -1061,7 +1062,8 @@ void crash_kexec(struct pt_regs *regs)
> machine_crash_shutdown(&fixed_regs);
> machine_kexec(kexec_crash_image);
> }
> - xchg(&kexec_lock, 0);
> + locked = xchg(&kexec_lock, 0);
> + BUG_ON(!locked);
> }
> }
On s390 I changed the xchg macro, so gcc 4.x doesn't warn anymore about unused
return values. Maybe something similar would be needed on other architectures
as well?
See commit 5a651c93d3a823af63b1b15bb94fdc951670fb2f .
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
