Jonathan Corbet wrote: > > * "name" is trivially unused. > > * Requirement to pass to unregister function anything but cookie you've > > got from register counterpart is wrong. > > Might this, instead, be an opportunity to get rid of the internal > register_chrdev() and unregister_chrdev() calls in favor of the cdev > interface? register_chrdev() is a bit of a backward-compatibility hack > at this point, and cdevs, in theory, are safer since they won't present > drivers with minor numbers they might not be prepared to handle. In this case I would suggest to add documentation to this functions first to get people the chance to actually know how to use them. Eike
Attachment:
pgpuUuYfJLLv5.pgp
Description: PGP signature
- Follow-Ups:
- cdev documentation (was Drop second arg of unregister_chrdev())
- From: [email protected] (Jonathan Corbet)
- Re: [PATCH] Drop second arg of unregister_chrdev()
- From: [email protected] (Jonathan Corbet)
- cdev documentation (was Drop second arg of unregister_chrdev())
- References:
- [PATCH] Drop second arg of unregister_chrdev()
- From: Alexey Dobriyan <[email protected]>
- Re: [PATCH] Drop second arg of unregister_chrdev()
- From: [email protected] (Jonathan Corbet)
- [PATCH] Drop second arg of unregister_chrdev()
- Prev by Date: Re: [PATCH] x86_64: Re-positioning the bss segment
- Next by Date: [PATCH] has_stopped_jobs cleanup
- Previous by thread: Re: [PATCH] Drop second arg of unregister_chrdev()
- Next by thread: Re: [PATCH] Drop second arg of unregister_chrdev()
- Index(es):
 |