On Tue, Aug 15, 2006 at 09:43:23AM +0200, Arjan van de Ven wrote:
> On Tue, 2006-08-15 at 02:46 -0400, Chuck Ebbert wrote:
> > In-Reply-To: <1155518783.5764.10.camel@localhost>
> >
> > On Mon, 14 Aug 2006 10:26:23 +0900, Magnus Damm wrote:
> >
> > > > > The different cpu_dev structures are all used from __cpuinit callers what
> > > > > I can tell. So mark them as __cpuinitdata instead of __initdata. I am a
> > > > > little bit unsure about arch/i386/common.c:default_cpu, especially when it
> > > > > comes to the purpose of this_cpu.
> > > >
> > > > But none of these CPUs supports hotplug and only one (AMD) does SMP.
> > > > So this is just wasting space in the kernel at runtime.
> > >
> > > How could this be wasting space? If you compile with CONFIG_HOTPLUG_CPU
> > > disabled then __cpuinitdata will become __initdata - ie the same as
> > > before. Not a single byte wasted what I can tell.
> >
> > I was talking about wasted space with HOTPLUG_CPU enabled, of course.
> > Nobody is ever going to hotplug a VIA, Cyrix, Geode, etc. CPU, yet your
> > patch makes the kernel carry that code and data anyway.
>
> remember that suspend uses software hot(un)plug as well...
Only for non-boot CPUs. The vendors above (with exception of VIA)
never made SMP systems.
Dave
--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
