Re: [PATCH 4/6] ehea: header files

On Sat, 2006-08-12 at 07:40 +1000, Anton Blanchard wrote:
> Hi,
> 
> >  drivers/net/ehea/ehea.h    |  452 
> 
> > +#define EHEA_DRIVER_NAME	"IBM eHEA"
> 
> You are using this for ethtool get_drvinfo. Im not sure if it should
> match the module name, and I worry about having a space in the name. Any
> ideas on what we should be doing here?

I believe it must match the module name. It also might be nice to call
it "DRV_NAME" like most other network drivers do.

cheers

-- 
Michael Ellerman
IBM OzLabs

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

Attachment: signature.asc
Description: This is a digitally signed message part

---

• Follow-Ups:
  • Re: [PATCH 4/6] ehea: header files
    • From: Jan-Bernd Themann <[email protected]>

• References:
  • [PATCH 4/6] ehea: header files
    • From: Jan-Bernd Themann <[email protected]>
  • Re: [PATCH 4/6] ehea: header files
    • From: Anton Blanchard <[email protected]>

• Prev by Date: Re: [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming
• Next by Date: Re: ext3 corruption
• Previous by thread: Re: [PATCH 4/6] ehea: header files
• Next by thread: Re: [PATCH 4/6] ehea: header files
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]