Re: powerpc: "make install" broken

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/12/06, Sam Ravnborg <[email protected]> wrote:
> I don't know if ever worked before, just tried today on v2.6.17.
> Maybe it works, but then it is very different to i386
> where it is plain "make install".
>
> I copied the implementation attached from i386 (modified a bit), which
> fixed it for me. Maybe the patch will motivate someone to fix it properly...
NACK - the install target shall not try to build the kernel - the
vmlinux dependency is long gone from i386.

Agreed, updated, rediffed, attached
(sorry for attach, that's gmail).
diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index ed5b26a..85b0c4b 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -156,6 +156,9 @@ boot := arch/$(ARCH)/boot
 $(BOOT_TARGETS): vmlinux
 	$(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@)
 
+install:
+	$(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) install
+
 define archhelp
   @echo '* zImage          - Compressed kernel image (arch/$(ARCH)/boot/zImage.*)'
   @echo '  install         - Install kernel using'
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 840ae59..6bfc3ec 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -209,7 +209,7 @@ extra-y		+= vmlinux.bin vmlinux.gz
 	@echo -n '  Image: $@ '
 	@if [ -f $@ ]; then echo 'is ready' ; else echo 'not made'; fi
 
-install: $(CONFIGURE) $(BOOTIMAGE)
-	sh -x $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)" "$(BOOTIMAGE)"
+install:
+	sh $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)"
 
 clean-files += $(addprefix $(objtree)/, $(obj-boot) vmlinux.strip)

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux