On Sat, Aug 12, 2006 at 01:49:23AM +0200, Thomas Koeller wrote:
> On Friday 11 August 2006 22:56, Dave Jones wrote:
> > On Thu, Aug 10, 2006 at 11:19:13PM +0200, [email protected] wrote:
> > > This is a driver for the on-chip watchdog device found on some
> > > MIPS RM9000 processors.
> > >
> > > Signed-off-by: Thomas Koeller <[email protected]>
> >
> > Mostly same nit-picking comments as your other driver..
>
> Which one?
The image capture driver.
> > > +#include <linux/config.h>
> >
> > not needed.
>
> It is, otherwise I do not get CONFIG_WATCHDOG_NOWAYOUT.
kbuild automatically includes it for you in the last few kernels.
> > As in the previous driver, are these barriers strong enough?
> > Or do they need explicit reads of the written addresses to flush the write?
>
> I think they are. Remember, the entire device is integrated in the
> processor. No external buses involved.
Ok.
Dave
--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
