On Fri, Aug 11, 2006 at 09:34:44AM -0400, Dmitry Torokhov wrote:
> How about we add backlight_set_power(&bd, power) to the backlight core
> to take care of proper locking for drivers?
I've tried to add several functions to the backlight core
({s,g}et_{brightness,power}) and they were rejected. Thus all the
locking is spread over the drivers. I agree it's faulty right now.
It's still easier to move to backlight core functions than to fix all
the drivers.
Because I am responsible/wrote for the broken code, how should I
proceed?
Attachment:
pgpI8CyPqmPjP.pgp
Description: PGP signature
- Follow-Ups:
- Re: [patch 5/6] Convert to use mutexes instead of semaphores
- From: "Dmitry Torokhov" <[email protected]>
- Re: [patch 5/6] Convert to use mutexes instead of semaphores
- References:
- [patch 0/6] Backlight & lcd fixes/cleanups
- From: Dmitry Torokhov <[email protected]>
- [patch 5/6] Convert to use mutexes instead of semaphores
- From: Dmitry Torokhov <[email protected]>
- Re: [patch 5/6] Convert to use mutexes instead of semaphores
- From: "Dmitry Torokhov" <[email protected]>
- Re: [patch 5/6] Convert to use mutexes instead of semaphores
- From: Richard Purdie <[email protected]>
- Re: [patch 5/6] Convert to use mutexes instead of semaphores
- From: "Dmitry Torokhov" <[email protected]>
- [patch 0/6] Backlight & lcd fixes/cleanups
- Prev by Date: Re: [PATCH 3/6] ehea: queue management
- Next by Date: Automatic namespace switch
- Previous by thread: Re: [patch 5/6] Convert to use mutexes instead of semaphores
- Next by thread: Re: [patch 5/6] Convert to use mutexes instead of semaphores
- Index(es):
 |