On Thu, 10.08.06 05:36, Brown, Len ([email protected]) wrote:
> Lennart,
Hi!
>
> Your s270 platform driver needs a different home in the source tree
> outside of drivers/acpi/, and the patch that adds it must add an entry
> to MAINTAINERS.
If you look closely you'll see that the patch already adds a new
entry to MAINTAINERS.
I put the the driver in drivers/acpi/ because it relies heavily on the
ACPI EC stuff. But OK, what is a better place for the driver?
drivers/char/
It doesn't even register any character device.
drivers/video/backlight/
It doesn't just do backlight control.
drivers/misc/
Seems to be the last resort for everything that doesn't fit it
otherwise.
Unless anyone has a better idea I will move it to drivers/misc/, then.
> lcd brightness platform support should talk to the existing
> backlight stuff under sysfs.
It already does exactly that, you can find the backlight class driver
in /sys/class/backlight/s270/.
I cannot map the "automatic brightness control" feature to the
backlight class driver, that's why I duplicated the brightness stuff
in /proc/acpi/s270/.
> wlan and bluetooth indicators/controls need to appear under
> generic places under sysfs -- not under platform specific
> files under /proc/acpi.
What are those "generic" places? I cannot think of any besides a
"platform" device.
> Yes, the existing platform specific drivers such as asus, toshiba, and
> ibm
> are bad examples.
Ok, I will move the /proc/acpi/s270/ stuff to a sysfs platform device,
then. I will cook up another patch shortly.
Any ideas on that ec_transaction() patch I sent earlier?
Lennart
--
Lennart Poettering; lennart [at] poettering [dot] net
ICQ# 11060553; GPG 0x1A015CC4; http://0pointer.net/lennart/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
