Re: [PATCH 3/9] support >32 bit ext4 filesystem block type in kernel

[Andrew Morton <akpm@osdl.org>]

On Wed, 09 Aug 2006 18:21:00 -0700
Mingming Cao <cmm@us.ibm.com> wrote:

> 
> Redefine ext4 in-kernel filesystem block type (ext4_fsblk_t) from unsigned
> long to sector_t, to allow kernel to handle  >32 bit ext4 blocks.
> 

I don't get it.

Randomly-chosen snippet:

> @@ -274,7 +274,8 @@ static int find_group_orlov(struct super
>  	freei = percpu_counter_read_positive(&sbi->s_freeinodes_counter);
>  	avefreei = freei / ngroups;
>  	freeb = percpu_counter_read_positive(&sbi->s_freeblocks_counter);
> -	avefreeb = freeb / ngroups;
> +	avefreeb = freeb;
> +	sector_div(avefreeb, ngroups);
>  	ndirs = percpu_counter_read_positive(&sbi->s_dirs_counter);
>  
>  	if ((parent == sb->s_root->d_inode) ||

Here, `avefreeb' is still a 32-bit type.  Why feed it into sector_div()?

> @@ -303,13 +304,15 @@ static int find_group_orlov(struct super
>  		goto fallback;
>  	}
>  
> -	blocks_per_dir = (le32_to_cpu(es->s_blocks_count) - freeb) / ndirs;
> +	blocks_per_dir = le32_to_cpu(es->s_blocks_count) - freeb;
> +	sector_div(blocks_per_dir, ndirs);

And here le32_to_cpu() is very much a 32-bit type.  Why sector_div()?

And I agree with me: we want to get all the sector_t's out of this
filesystem.  unsigned long long, do_div()?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/