Re: XFS warning in 2.6.18-rc4

[Alexey Dobriyan <adobriyan@gmail.com>]

On Wed, Aug 09, 2006 at 11:04:53PM +0300, Meelis Roos wrote:
> fs/xfs/xfs_bmap.c: In function 'xfs_bmapi':
> fs/xfs/xfs_bmap.c:2662: warning: 'rtx' is used uninitialized in this function

gcc bug again? Corresponding preprocessed source when XFS realtime allocator
is off:

static int xfs_bmap_rtalloc(xfs_bmalloca_t *ap)
{
		...
	xfs_rtblock_t rtx;

		...
	if (ap->eof && ap->off == 0) {
===>		error = (251);		<===
		if (error)
			return error;
		ap->rval = rtx * mp->m_sb.sb_rextsize;
	} else {
		ap->rval = 0;
	}

This is the only place where rtx is "used".

When realtime allocator is on, xfs_rtpick_extent() is real function
either a) returning error and leaving garbage in "rtx", or b)
initializing "rtx" and returning 0.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/