On Wed, Aug 09, 2006 at 11:01:45AM -0500, David Smith wrote:
> > + if (p->symbol_name) {
> > + if (p->addr)
> > + return -EINVAL;
> > + p->addr = kprobe_lookup_name(p->symbol_name) + p->offset;
> > + }
>
> What if kprobe_lookup_name() fails
for that case we need the check in your snipplet below.
> or if CONFIG_KALLSYMS isn't set?
I think we should just disallow that case. having kprobes without kallsyms
is rather pointless. I'll send a patch to add the dependency to the Kconfig
files.
> Perhaps this needs something like:
>
> if (p->symbol_name) {
> if (p->addr)
> return -EINVAL;
> p->addr = kprobe_lookup_name(p->symbol_name) + p->offset;
> if (p->addr == p->offset)
> return -EINVAL;
> }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
