On Wednesday 09 August 2006 03:03, Magnus Damm wrote:
> i386: remove redundant generic_identify() calls when identifying cpus
>
> cpu_dev->c_identify is only called from arch/i386/common.c:identify_cpu(), and
> this after generic_identify() already has been called. There is no need to call
> this function twice and hook it in c_identify - but I may be wrong, please
> double check before applying.
>
> This patch also removes generic_identify() from cpu.h to avoid unnecessary
> future nesting.
There are sometimes subtle interactions with this (e.g. with parameters
changing flags and then someone else overwriting them again)
But agreed it seems bogus to call it twice.
I guess the only way to find out how much it breaks is to merge it.
-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
