Re: [PATCH 10/12] hdaps: Power off accelerometer on suspend and unload

Hi,

On 8/8/06, Pavel Machek <[email protected]> wrote:

> +     if (hdaps_set_power(0))
> +             printk(KERN_WARNING "hdaps: cannot power off\n");
> +     if (hdaps_set_ec_config(0, 1))
> +             printk(KERN_WARNING "hdaps: cannot stop EC sampling\n");
> +}

Maybe propagate error value?

I could do that, but both callers will still discard it -- the power
draw change is negligible, and it's not interesting enough to abort
either suspend or module unload.

OK on all remaining comments.

I'll wait a bit for additional comments and then post the revised series.

 Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 00/12] ThinkPad embedded controller and hdaps drivers
    • From: Shem Multinymous <[email protected]>
  • [PATCH 10/12] hdaps: Power off accelerometer on suspend and unload
    • From: Shem Multinymous <[email protected]>
  • Re: [PATCH 10/12] hdaps: Power off accelerometer on suspend and unload
    • From: Pavel Machek <[email protected]>

• Prev by Date: [PATCH 3/3] ppc32: board-specific part of fs_enet update
• Next by Date: Re: [PATCH 04/12] hdaps: Correct readout and remove nonsensical attributes
• Previous by thread: Re: [PATCH 10/12] hdaps: Power off accelerometer on suspend and unload
• Next by thread: [PATCH 03/12] hdaps: Unify and cache hdaps readouts
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]