Fix i_state of the inode is changed after the inode is freed.
Signed-off-by: Masayuki Saito <[email protected]>
---
--- linux-2.6.17.7/fs/xfs/xfs_inode.c.orig 2006-08-01 14:20:00.903511531 +0900
+++ linux-2.6.17.7/fs/xfs/xfs_inode.c 2006-08-01 14:14:39.588213059 +0900
@@ -2736,6 +2736,8 @@ void
xfs_iunpin(
xfs_inode_t *ip)
{
+ int need_unlock;
+
ASSERT(atomic_read(&ip->i_pincount) > 0);
if (atomic_dec_and_test(&ip->i_pincount)) {
@@ -2751,6 +2753,8 @@ xfs_iunpin(
* call as the inode reclaim may be blocked waiting for
* the inode to become unpinned.
*/
+ need_unlock = 1;
+ spin_lock(&ip->i_flags_lock);
if (!(ip->i_flags & (XFS_IRECLAIM|XFS_IRECLAIMABLE))) {
vnode_t *vp = XFS_ITOV_NULL(ip);
@@ -2758,10 +2762,22 @@ xfs_iunpin(
if (vp) {
struct inode *inode = vn_to_inode(vp);
- if (!(inode->i_state & I_NEW))
- mark_inode_dirty_sync(inode);
+ if (!(inode->i_state &
+ (I_NEW|I_FREEING|I_CLEAR))) {
+ inode = igrab(inode);
+ if (inode != NULL) {
+ mark_inode_dirty_sync(inode);
+ spin_unlock(&ip->i_flags_lock);
+ need_unlock = 0;
+ iput(inode);
+ }
+ }
}
}
+ if (need_unlock) {
+ spin_unlock(&ip->i_flags_lock);
+ need_unlock = 0;
+ }
wake_up(&ip->i_ipin_wait);
}
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
