Re: [PATCH] unserialized task->files changing

On Tue, Aug 08, 2006 at 02:07:49PM +0400, Kirill Korotaev wrote:
> Fixed race on put_files_struct on exec with proc.
> Restoring files on current on error path may lead
> to proc having a pointer to already kfree-d files_struct.

This is three times the exact same code sequence, it should probably go into
a helper:

void reset_current_files(struct files_struct *files)
{
	struct files_struct *old = current->files;

	task_lock(current);
	current->files = files;
	task_unlock(current);
	put_files_struct(old);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] unserialized task->files changing
    • From: Eric Dumazet <[email protected]>

• References:
  • [PATCH] unserialized task->files changing
    • From: Kirill Korotaev <[email protected]>

• Prev by Date: Re: Is XFS trustworthy in the latest 2.6.16
• Next by Date: Re: Only 3.2G ram out of 4G seen in an i386 box
• Previous by thread: [PATCH] unserialized task->files changing
• Next by thread: Re: [PATCH] unserialized task->files changing
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]